Open documents using testClient.openDocument instead of constructing a DidOpenDocumentNotification
#910
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g a `DidOpenDocumentNotification` This removes a lot of boilerplate and makes the tests easier to read.
|
@swift-ci Please test |
bnbarham
approved these changes
Oct 19, 2023
| //===----------------------------------------------------------------------===// | ||
|
|
||
| /// Finds all marked ranges in the given text, see `Marker`. | ||
| fileprivate func findMarkedRanges(text: String) -> [Marker] { |
There was a problem hiding this comment.
I haven't checked, is this basically just a copy paste from swift-syntax 😅?
There was a problem hiding this comment.
Yes, this is a copy-paste from swift-syntax 😢
| extension Language { | ||
| var fileExtension: String { | ||
| switch self { | ||
| case .objective_c: return "m" |
There was a problem hiding this comment.
objective_cpp could probably use a value here as well, though I assume we don't have tests with it?
There was a problem hiding this comment.
Yeah, I wanted to add a case here once/if we ever have an Objective-C++ test case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of constructing a
DidOpenTextDocumentNotificationinside the tests, add aTestSourceKitLSPClient.openDocumentmethod that opens a document. In addition to being shorter to write than theDidOpenTextDocumentNotification, it does two smart things:1️⃣) and returns their positions, which means that we don’t need to write fragile line-column based positions in the test files. Migrating all the tests from line-column basedPositioninitializers to use location markers is quite a big change and not part of this PR.