Automatically initialize the SourceKit-LSP server when creating a TestSourceKitLSPClient
#911
Conversation
ahoppen
changed the title
TestSoruceKitLSPClientTestSourceKitLSPClient
…stSourceKitLSPClient` Sending the `InitializeRequest` was always unnecessarily verbose. If we automatically initialize the server when creating the test client, the code becomes sufficiently concise that we can set up the client + server in the test method itself and no longer need the `setUp` methods, making the tests easier to read.
ahoppen
force-pushed
the
ahoppen/auto-initialize-server
branch
from
02c6062 to
70997db
Compare
|
@swift-ci Please test |
| ), | ||
| trace: .off, | ||
| workspaceFolders: nil | ||
| private let quickFixCapabilities = ClientCapabilities( |
There was a problem hiding this comment.
Could be static. I don't know if we want eg. a separate support enum that has the common ones we use, but quickFix seems to be used in a few places outside this test file as well.
There was a problem hiding this comment.
I would like to leave these local to the test cases. In my experience what would happen otherwise is that we need another capability in addition to quickFix in some other test case and it just gets added to the support enum. Also, at the moment it’s only duplicated once, so not too bad.
Regarding static: I’d prefer to leave it as a member because otherwise we need to refer to it as Self.quickFixCapabilities which doesn’t read as nice. And it’s not like it makes a huge performance difference.
Sending the
InitializeRequestwas always unnecessarily verbose. If we automatically initialize the server when creating the test client, the code becomes sufficiently concise that we can set up the client + server in the test method itself and no longer need thesetUpmethods, making the tests easier to read.