Add infrastructure to define indexed single-file workspaces inside the tests #914
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bnbarham
reviewed
Oct 20, 2023
hamishknight
approved these changes
Oct 23, 2023
ahoppen
force-pushed
the
ahoppen/single-indexed-file-workspace
branch
from
0018e14 to
0f29a1d
Compare
I migrated a bunch more tests from the TIBS-based test inputs to define the test inputs inline. I haven’t really needed to make any adjustments to the test workspaces for the last few migrations, so I think the design is more or less complete and it’s now just a matter of converting the remaining test cases to the new infrastructure. |
ahoppen
force-pushed
the
ahoppen/single-indexed-file-workspace
branch
from
0f29a1d to
734e4e1
Compare
|
And today I learned about |
|
@swift-ci Please test |
bnbarham
reviewed
Oct 24, 2023
…e tests The new approach has a few advantages over the olde TIBS-based approach: 1. The source file being tested is defined within the test case itself and not in a separate file, which makes it easier to understand the test case since the auxiliaury file doesn’t need to be opened. Finding it inside `Sources/SKTestSupport/INPUTS` is already hard for people that are not familiar with the codebase. 2. The build setup is significantly simpler since it doesn’t rely on `ninja`. It is thus easier to understand what is run during the test. 3. We can use the emoji location markers to refer to test locations, like we do for files that are opened using `TestSourceKitLSPClient.openDocument`. This commit only migrates call hierarchy testing to the new design. If we like it, I’ll migrate the other test workspaces as well.
…orkspace that can be opened in SourceKitLSP
We don’t actually need on-disk files here and can just open them in memory.
We can just open the file in-memory instead
The tests never performed any cross-file testing so we can just import them as standalone files in-memory.
… arbitrary languages This allows us to remove the `BasicCXX` test directory.
ahoppen
force-pushed
the
ahoppen/single-indexed-file-workspace
branch
from
734e4e1 to
48b617c
Compare
|
@swift-ci Please test |
|
@swift-ci Please test Windows |
bnbarham
approved these changes
Oct 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new approach has a few advantages over the olde TIBS-based approach:
Sources/SKTestSupport/INPUTSis already hard for people that are not familiar with the codebase.ninja. It is thus easier to understand what is run during the test.TestSourceKitLSPClient.openDocument.This commit only migrates call hierarchy testing to the new design. If we like it, I’ll migrate the other test workspaces as well.