Skip to content

Output a --- marker to mark the end of a log message in NonDarwinLogger #919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 25, 2023

Conversation

ahoppen
Copy link
Member

@ahoppen ahoppen commented Oct 24, 2023

Figuring out where one log message ends and the next one starts is a little tricky. A --- marker helped me a lot to find the boundary between two log messages.

@ahoppen ahoppen requested a review from bnbarham October 24, 2023 15:27
@ahoppen ahoppen requested a review from benlangmuir as a code owner October 24, 2023 15:27
@ahoppen
Copy link
Member Author

ahoppen commented Oct 24, 2023

@swift-ci Please test

…ogger`

Figuring out where one log message ends and the next one starts is a little tricky. A `---` marker helped me a lot to find the boundary between two log messages.
@ahoppen ahoppen force-pushed the ahoppen/log-separator branch from 1a7fcc8 to cb21f9a Compare October 25, 2023 00:56
@ahoppen
Copy link
Member Author

ahoppen commented Oct 25, 2023

@swift-ci Please test

@ahoppen
Copy link
Member Author

ahoppen commented Oct 25, 2023

@swift-ci Please test Windows

@ahoppen ahoppen merged commit 640abbb into swiftlang:main Oct 25, 2023
@ahoppen ahoppen deleted the ahoppen/log-separator branch October 25, 2023 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants