Skip to content

Implement the document color request using the SwiftSyntax tree #925

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 26, 2023
Merged

Implement the document color request using the SwiftSyntax tree #925

merged 1 commit into from
Oct 26, 2023

Conversation

ahoppen
Copy link
Member

@ahoppen ahoppen commented Oct 25, 2023

No description provided.

@ahoppen ahoppen requested a review from benlangmuir as a code owner October 25, 2023 21:17
bnbarham
bnbarham approved these changes Oct 25, 2023
View reviewed changes
Copy link
Contributor

@bnbarham bnbarham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could also look for strings matching #[a-zA-Z0-9]{6} :P

What does this actually show up as in eg. VSCode right now? Does picking a color insert the actual hex value instead of what we expect (ie. #colorLiteral(...))?

@ahoppen
Copy link
Member Author

ahoppen commented Oct 26, 2023

@swift-ci Please test

@ahoppen ahoppen merged commit b7063a8 into swiftlang:main Oct 26, 2023
@ahoppen ahoppen deleted the ahoppen/document-color-syntax branch October 26, 2023 16:34
@ahoppen ahoppen mentioned this pull request Oct 27, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bnbarham bnbarham bnbarham approved these changes

@hamishknight hamishknight hamishknight approved these changes

@benlangmuir benlangmuir Awaiting requested review from benlangmuir

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ahoppen @bnbarham @hamishknight