Skip to content

Minor improvements to SwiftLanguageServer.swift #927

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 26, 2023
Merged

Minor improvements to SwiftLanguageServer.swift #927

merged 3 commits into from
Oct 26, 2023

Conversation

ahoppen
Copy link
Member

@ahoppen ahoppen commented Oct 26, 2023

  • Introduce a new sub-logging scope for the implicitly triggered publish diagnostics notification
    • Just makes it clearer why some logs are being triggered if you know that it’s for the publish diagnostics notification.
  • Don’t log a fault if the publish diagnostics notification is cancelled
    • Cancelling the publish diagnostics notificaiton because there was an edit is totally normal and nothing to be logged at the fault level.
  • Format SwiftLanguageServer.swift

@ahoppen
Introduce a new sub-logging scope for the implicitly triggered publis…
a1f909a 
…h diagnostics notification

Just makes it clearer why some logs are being triggered if you know that it’s for the publish diagnostics notification.
@ahoppen
Don’t log a fault if the publish diagnostics notification is cancelled
59cc291 
Cancelling the publish diagnostics notificaiton because there was an edit is totally normal and nothing to be logged at the `fault` level.
@ahoppen
Format SwiftLanguageServer.swift
69d22da
@ahoppen ahoppen requested a review from benlangmuir as a code owner October 26, 2023 04:24
@ahoppen
Copy link
Member Author

ahoppen commented Oct 26, 2023

@swift-ci Please test

@ahoppen ahoppen merged commit 87dd95e into swiftlang:main Oct 26, 2023
@ahoppen ahoppen deleted the ahoppen/mini-improvements branch October 26, 2023 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hamishknight hamishknight hamishknight approved these changes

@bnbarham bnbarham Awaiting requested review from bnbarham bnbarham is a code owner

@benlangmuir benlangmuir Awaiting requested review from benlangmuir

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ahoppen @hamishknight