When sourcekitd crashes, log the file contents with which it crashed and the request #933
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bnbarham
reviewed
Oct 27, 2023
| // FIXME: Ideally we could log the request key here at the info level but the dictionary is | ||
| // readonly. | ||
| logger.log( | ||
| logger.info( |
There was a problem hiding this comment.
What's default vs info? The docs weren't particularly illuminating.
There was a problem hiding this comment.
There was a problem hiding this comment.
Ah, so persisted vs not 👍
ahoppen
changed the title
ahoppen
force-pushed
the
ahoppen/log-sourcekitd-crash-info
branch
from
6228f3d to
fb3bc8c
Compare
ahoppen
changed the title
|
@swift-ci Please test |
Comment on lines
+112
to
+109
| for (index, chunk) in chunks.enumerated() { | ||
| logger.fault( | ||
| """ | ||
| sourcekitd crashed (\(index + 1)/\(chunks.count)) | ||
| \(chunk) | ||
| """ | ||
| ) | ||
| } |
There was a problem hiding this comment.
If OSLog treats this as private (which I believe is the default?), will we just log multiple sourcekitd crashed lines with redacted chunks?
There was a problem hiding this comment.
Yes, we will. It’s a big unfortunate but I don’t have any better idea.
ahoppen
force-pushed
the
ahoppen/log-sourcekitd-crash-info
branch
from
fb3bc8c to
def98da
Compare
|
@swift-ci Please test |
ahoppen
force-pushed
the
ahoppen/log-sourcekitd-crash-info
branch
from
def98da to
4af0f71
Compare
|
@swift-ci Please test |
|
@swift-ci Please test Windows |
1 similar comment
|
@swift-ci Please test Windows |
…and the request This should make it a lot easier to reproduce sourcekitd crashes.
ahoppen
force-pushed
the
ahoppen/log-sourcekitd-crash-info
branch
from
4af0f71 to
1a23153
Compare
|
@swift-ci Please test |
|
@swift-ci Please test Windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should make it a lot easier to reproduce sourcekitd crashes.