Make the LanguageServerProtocol module dependency-free
#945
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahoppen
force-pushed
the
ahoppen/language-server-protocol-dependency-free
branch
from
f1f329e to
f6bce95
Compare
hamishknight
approved these changes
Oct 27, 2023
Comment on lines
35
to
44
| extension DocumentURI: CustomLogStringConvertible { | ||
| public var redactedDescription: String { | ||
| return "<DocumentURI length=\(description.count) hash=\(description.hashForLogging)>" | ||
| } | ||
| } | ||
|
|
||
| // MARK: - RequestType | ||
|
|
||
| fileprivate struct AnyRequestType: CustomLogStringConvertible { |
There was a problem hiding this comment.
FWIW SE-0364 will eventually require these to be marked @retroactive since they're conformances of external types to external protocols
There was a problem hiding this comment.
Yeah, I need to address these warnings across the entire codebase. I’ll probably create a PR in the next week or so when I get annoyed by the warnings again.
ahoppen
force-pushed
the
ahoppen/language-server-protocol-dependency-free
branch
from
f6bce95 to
ecb2bf6
Compare
ahoppen
changed the title
LanguageServerProtocol module dependency-free 🚥 #937LanguageServerProtocol module dependency-free
|
@swift-ci Please test |
Shuffle a few types around so that the `LanguageServerProtocol` has no more dependencies. Fixes swiftlang#938 rdar://117565087
ahoppen
force-pushed
the
ahoppen/language-server-protocol-dependency-free
branch
from
ecb2bf6 to
aa70fc0
Compare
|
@swift-ci Please test |
|
@swift-ci Please test Windows |
|
This seems to have broken the Windows build :/ |
compnerd
added a commit
to compnerd/sourcekit-lsp
that referenced
this pull request
Nov 1, 2023
The changes in swiftlang#945 changed the dependencies but did not correct them in the CMakeLists.txt resulting in a broken build.
compnerd
added a commit
to compnerd/sourcekit-lsp
that referenced
this pull request
Nov 1, 2023
The changes in swiftlang#945 changed the dependencies but did not correct them in the CMakeLists.txt resulting in a broken build. Resynchronise the dependencies across Package.swift and CMake.
compnerd
added a commit
to compnerd/sourcekit-lsp
that referenced
this pull request
Nov 1, 2023
The changes in swiftlang#945 changed the dependencies but did not correct them in the CMakeLists.txt resulting in a broken build. Resynchronise the dependencies across Package.swift and CMake.
compnerd
added a commit
that referenced
this pull request
Nov 1, 2023
The changes in #945 changed the dependencies but did not correct them in the CMakeLists.txt resulting in a broken build. Resynchronise the dependencies across Package.swift and CMake.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shuffle a few types around so that the
LanguageServerProtocolhas no more dependencies.Fixes #938
rdar://117565087