Remove assertion that we can't register for change notifications twice in SwiftPMWorkspace
#949
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hamishknight
approved these changes
Oct 27, 2023
…cations` The language wasn’t used anywhere.
…e in `SwiftPMWorkspace` There’s no harm in registering for change notifications for the same file twice. Currently, this can happen if you open two files that have the same main file. `BuildSystemManager` checks that there are no more files referencing a main file before calling `unregisterForChangeNotifications`, so this is where the “complicated” logic lives that checks if sourcekit-lsp really isn’t interested in a file anymore. rdar://117603105
ahoppen
force-pushed
the
ahoppen/fix-unbalanced-register-unregister-crash
branch
from
7140ca3 to
4a924c4
Compare
|
@swift-ci Please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There’s no harm in registering for change notifications for the same file twice. Currently, this can happen if you open two files that have the same main file.
BuildSystemManagerchecks that there are no more files referencing a main file before callingunregisterForChangeNotifications, so this is where the “complicated” logic lives that checks if sourcekit-lsp really isn’t interested in a file anymore.While looking through the code I noticed that I could remove the
languageparameter fromBuildSystem.registerForChangeNotificationsbecause it isn’t used anywhere.rdar://117603105