Emit signposts for request handling #951
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test |
hamishknight
approved these changes
Oct 27, 2023
bnbarham
approved these changes
Oct 27, 2023
This allows you to trace sourcekit-lsp in Instruments to get a feeling for how long requests take to be handled.
ahoppen
force-pushed
the
ahoppen/signpost
branch
from
e2cad5f to
47e7a13
Compare
|
@swift-ci Please test |
|
@swift-ci Please test Windows |
1 similar comment
|
@swift-ci Please test Windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows you to trace sourcekit-lsp in Instruments to get a feeling for how long requests take to be handled. I’m not sure how useful this will be in practice but we can’t really know until we have it in a build that we see an issue with, so I’d propose we put it in and if we never use it in the next year or two, we can rip it back out again.