Implement document symbol request #98
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trzyipolkostkicukru
force-pushed
the
cukr/document-symbol
branch
from
c03a07a to
eb8ea96
Compare
benlangmuir
suggested changes
May 2, 2019
There was a problem hiding this comment.
Thanks a lot for the PR! The code changes are looking pretty good to a first look, I just left a few inline comments. I haven't dug into the details of the specification for this request, so I'll probably do another round of detailed review when I have a chance to look at that.
One important thing that's missing is tests. The FoldingRangeTests are a good model to look at for how to setup the test server, provide document contents, etc.
|
@swift-ci please test |
benlangmuir
reviewed
May 29, 2019
|
@swift-ci please test |
benlangmuir
approved these changes
May 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I implemented document symbol request, which enables "document outline" in visual studio code.
I have no experience with contributing features to open source, I tried to match the style of the rest of the project. Are there any things I have to change/add?