Decode RegistrationOptions

[krzyzanowskim]

Decode RegistrationOptions from LSPAny

[ahoppen]

What’s the use case for decoding RegistrationOptions from LSPAny?

[krzyzanowskim]

symmetric to encodeIntoLSPAny. If the server talk to the client, the client may want to decode options sent from the server. I work on a LSP client that uses LanguageServerProtocol as a dependency for model and decode the value on the client side.

[ahoppen]

Ideally, we should make these types conform to LSPAnyCodable.

[krzyzanowskim]

Ideally, we should make these types conform to LSPAnyCodable.

You're not wrong. It's so much more work. I'll try

[ahoppen]

Thank you 🙏🏽 I hope it’s not too much more

[krzyzanowskim]

The LSPAnyCodable is here d718f46

[ahoppen]

Thank you for making the types conform to LSPAnyCodable 🙏🏽 Much cleaner.

I have some comments regarding consistency of de/encoding.

[ahoppen]

Thank you! I have one minor comment left, otherwise LGTM.

[ahoppen]

@swift-ci Please test

[ahoppen]

@swift-ci Please test Windows

[krzyzanowskim]

@swift-ci Please test macOS

[krzyzanowskim]

I don’t think I have the power to re-run macOS test. It failed without a reason @ahoppen

[ahoppen]

Ah, macOS CI failed because the code isn’t formatted correctly. Could you run swift-format on it?

Sorry, we don’t have any documentation for that at the moment, I usually build swift-format locally and then run

cd /path/to/sourcekit-lsp
/path/to/swift-format/.build/arm64-apple-macosx/release/swift-format format -i --recursive Sources/ Tests/ Package.swift

[ahoppen]

@swift-ci Please test

[ahoppen]

@swift-ci Please test Windows

[ahoppen]

@swift-ci Please test Windows