Add semantic highlighting for function parameter labels #983
Conversation
ahoppen
force-pushed
the
ahoppen/parameter-highlighting
branch
from
6a2ef94 to
b8420eb
Compare
|
@swift-ci Please test |
|
There's some documentation, just not in the specification itself - https://code.visualstudio.com/api/language-extensions/semantic-highlight-guide#standard-token-types-and-modifiers. IMO the argument name (first name) should be Is the screenshot you included just from the syntax tree, or does it include the semantic tokens? |
|
Good idea with just considering the labels part of the function itself.
It includes semantic tokens. The two states of syntax highlighting that we have in LSP land are
|
ahoppen
force-pushed
the
ahoppen/parameter-highlighting
branch
from
b8420eb to
cb078c2
Compare
| Token(line: 6, utf16index: 7, length: 8, kind: .struct), | ||
| ] | ||
| ) | ||
| } | ||
|
|
||
| func testArgumentLabels() async throws { |
There was a problem hiding this comment.
Do we have a first + second name test at all? Is the second name a parameter or an identifier?
There was a problem hiding this comment.
We do have a test for it in swift-syntax: https://github.com/apple/swift-syntax/pull/2375/files#diff-0f770f38aaec515fed644ee83824ed0dcfb2e86ec67a6da535f2de9fef15f9f3R531
There was a problem hiding this comment.
Fair enough, I'd expect one here too since the sourcekitd response could add more information if it wanted to (eg. all params + references could be "parameters").
|
@swift-ci Please test |
ahoppen
force-pushed
the
ahoppen/parameter-highlighting
branch
from
cb078c2 to
7424558
Compare
|
@swift-ci Please test |
|
@swift-ci Please test Windows |
This highlights
argin the following as aparameter.LSP doesn’t explicitly state what
parametermeans.clangdusesparameterfor parameter declarations, Python also usesparameterfor parameter labels.Here’s how syntax coloring looks with this patch in VS Code with the GitHub light theme (underlined are the changed tokens).
Companion of swiftlang/swift-syntax#2375.