Allow configuring workspace type via flag #988
Conversation
|
Thanks for the quick review! I've made local changes per your inline suggestions. To support per-workspace configuration, am I correct in understanding this would be a configuration setting in the Swift VSCode extension? (Most likely extending this interface https://github.com/swift-server/vscode-swift/blob/4822e95cde97928a176f05a08e4e7ff581297ee7/src/configuration.ts#L45 ) |
The goal here is to expose these configuration options from sourcekit-lsp. Adding configuration to the VS Code Swift extension would be a second step. AFAIK the VS Code Swift extension doesn’t have the capability to set any of the workspace-specific parameter offered by #974 yet but it’s something that we want to add in the future. And since the release cycles of sourcekit-lsp are longer than those of the VS Code extension (since it’s tied to the Swift releases), it’s good to design for these configuration options. So, to clarify: I’m not asking you to also modify the VS Code Swift extension. |
Sources/LanguageServerProtocol/SupportTypes/WorkspaceFolder.swift
Outdated
Show resolved
Hide resolved
|
@swift-ci Please test |
|
Okay, I think I fixed the tests. I'm developing on Windows with limited testing support, but I was able to get things set up in Windows subsystem for Linux so that I could compile the tests. Thanks for your patience 🙏 |
|
@swift-ci Please test |
|
@swift-ci Please test Windows |
1 similar comment
|
@swift-ci Please test Windows |
Head branch was pushed to by a user without write access
|
@swift-ci Please test |
|
@swift-ci Please test Windows |
Fixes #984
I opted to log an error and continue with no build system set if the selected workspace type fails to create. A reasonable alternative might be to fall back to default selection logic, but this might make it harder to tell if something is wrong.