Implement local rename within the current file #990
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test |
ahoppen
force-pushed
the
ahoppen/rename
branch
from
b349967 to
958fd99
Compare
|
@swift-ci Please test |
bnbarham
reviewed
Dec 8, 2023
| func 1️⃣foo(a: Int) {} | ||
| foo(a: 1) | ||
| """, | ||
| newName: "bar ( x : )", |
There was a problem hiding this comment.
I'd prefer ignoring personally, any argument for keeping it?
There was a problem hiding this comment.
Like, you would prefer to strip the parameter names? I feel like people should be allowed to misuse the rename tool for all the weird formatting styles they have.
There was a problem hiding this comment.
Well, name in general. I think it would be more common for someone to accidentally have a space than to actually want it. But we can try it and see 🤷
ahoppen
force-pushed
the
ahoppen/rename
branch
from
958fd99 to
cffdada
Compare
ahoppen
added a commit
to ahoppen/sourcekit-lsp
that referenced
this pull request
Dec 9, 2023
ahoppen
force-pushed
the
ahoppen/rename
branch
from
cffdada to
f077d10
Compare
|
@swift-ci Please test |
ahoppen
added a commit
to ahoppen/sourcekit-lsp
that referenced
this pull request
Dec 9, 2023
|
@swift-ci Please test Windows |
This allows use to re-use related identifiers when implementing rename
rdar://117822427
ahoppen
force-pushed
the
ahoppen/rename
branch
from
f077d10 to
6b5842f
Compare
|
@swift-ci Please test |
ahoppen
added a commit
to ahoppen/sourcekit-lsp
that referenced
this pull request
Dec 9, 2023
|
@swift-ci Please test Windows |
ahoppen
added a commit
to ahoppen/sourcekit-lsp
that referenced
this pull request
Dec 12, 2023
ahoppen
added a commit
to ahoppen/sourcekit-lsp
that referenced
this pull request
Dec 12, 2023
ahoppen
added a commit
to ahoppen/sourcekit-lsp
that referenced
this pull request
Dec 13, 2023
ahoppen
added a commit
to ahoppen/sourcekit-lsp
that referenced
this pull request
Dec 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bit of refactoring and then implements rename within the current file by using the
relatedidentsrequest to get the locations to rename andfind-syntactic-rename-rangesto get the ranges to rename.rdar://117822427