Install name mapping not specifying the correct platform number (rdar://144577495) #147
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…form number The `$ld$previous` syntax used to map a renamed debug dylib for previews does not properly set the platform field. This plumbs them through as a new computed build macro and checks it in the previews settings test when `LD_CLIENT_NAME` is used.
jonathanpenn
requested review from
jakepetroules,
mirza-garibovic,
mhrawdon,
neonichu and
owenv
as code owners
|
@swift-ci test |
jakepetroules
approved these changes
Feb 12, 2025
neonichu
approved these changes
Feb 12, 2025
owenv
approved these changes
Feb 12, 2025
|
The ubuntu CI had issues prior to my change. The failure I see is unrelated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
$ld$previoussyntax used to map a renamed debug dylib for previews does not properly set the platform field.This plumbs them through as a new computed build macro and checks it in the previews settings test when
LD_CLIENT_NAMEis used.