Begin adding support for using swiftc as a linker driver #236
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
| args += ["-compatibility_version", compatibilityVersion] | ||
| switch scope.evaluate(BuiltinMacros.LINKER_DRIVER) { | ||
| case .clang: | ||
| args += ["-compatibility_version", compatibilityVersion] |
There was a problem hiding this comment.
Any reason to prefer the driver option at all vs just using Xlinker? Does -compatibility_version at the clang level actually do anything?
There was a problem hiding this comment.
It doesn't have any behavior I know of but I'd prefer to use driver options whenever possible for maximum compatibility
owenv
force-pushed
the
swiftc-linker-driver
branch
from
3729cde to
4506efc
Compare
|
@swift-ci test Linux |
owenv
force-pushed
the
swiftc-linker-driver
branch
from
4506efc to
9022e09
Compare
|
@swift-ci test |
owenv
force-pushed
the
swiftc-linker-driver
branch
from
9022e09 to
8aa2101
Compare
|
@swift-ci test |
owenv
force-pushed
the
swiftc-linker-driver
branch
from
8aa2101 to
7354e45
Compare
|
@swift-ci test |
owenv
force-pushed
the
swiftc-linker-driver
branch
from
7354e45 to
f48504d
Compare
|
@swift-ci test |
owenv
force-pushed
the
swiftc-linker-driver
branch
from
f48504d to
647b134
Compare
|
@swift-ci test linux |
owenv
force-pushed
the
swiftc-linker-driver
branch
from
647b134 to
14f6908
Compare
|
@swift-ci test linux |
owenv
force-pushed
the
swiftc-linker-driver
branch
from
14f6908 to
64337e3
Compare
|
@swift-ci test linux |
owenv
force-pushed
the
swiftc-linker-driver
branch
from
64337e3 to
eed2eb1
Compare
|
@swift-ci test linux |
|
@swift-ci test macOS |
|
@swift-ci test windows |
owenv
force-pushed
the
swiftc-linker-driver
branch
from
eed2eb1 to
3a36033
Compare
|
@swift-ci test |
|
@swift-ci test Windows |
owenv
force-pushed
the
swiftc-linker-driver
branch
from
3a36033 to
c1ed45a
Compare
|
@swift-ci test |
owenv
force-pushed
the
swiftc-linker-driver
branch
from
c1ed45a to
54ef5be
Compare
|
@swift-ci test Windows |
1 similar comment
|
@swift-ci test Windows |
|
@swift-ci test Windows |
|
@swift-ci test |
owenv
force-pushed
the
swiftc-linker-driver
branch
from
54ef5be to
6473758
Compare
|
@swift-ci test Windows |
owenv
force-pushed
the
swiftc-linker-driver
branch
from
6473758 to
71c9bc5
Compare
|
@swift-ci test Windows |
owenv
force-pushed
the
swiftc-linker-driver
branch
from
71c9bc5 to
8c23c59
Compare
|
@swift-ci test Windows |
owenv
force-pushed
the
swiftc-linker-driver
branch
from
8c23c59 to
52923db
Compare
|
@swift-ci test |
This is controlled via the LINKER_DRIVER setting
owenv
force-pushed
the
swiftc-linker-driver
branch
from
52923db to
47e61e8
Compare
|
@swift-ci test |
owenv
requested review from
mirza-garibovic,
mhrawdon and
neonichu
as code owners
neonichu
approved these changes
Apr 2, 2025
| @@ -234,7 +234,13 @@ public final class LdLinkerSpec : GenericLinkerSpec, SpecIdentifierType, @unchec | |||
| public static let identifier = "com.apple.pbx.linkers.ld" | |||
|
|
|||
| public override func computeExecutablePath(_ cbc: CommandBuildContext) -> String { | |||
| return cbc.producer.hostOperatingSystem.imageFormat.executableName(basename: "clang") | |||
| // TODO: We should also provide an "auto" option which chooses based on the source files in the target | |||
There was a problem hiding this comment.
I do remember there being some subtle differences between linker drivers for C sources as well, so "auto" could result in surprises.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is controlled via the LINKER_DRIVER setting
This is enough to at least link a basic CLI tool on macOS. It needs some more work and tests still