Previews break with explicit modules enabled <rdar://146184835> #259
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathanpenn
requested review from
jakepetroules,
mirza-garibovic,
mhrawdon,
neonichu and
owenv
as code owners
With the new previews execution mode, we don't need to be as aggressive stripping compiler flags for thunk builds like we did for the old dynamic replacement execution mode. And doing so actually breaks when explicit modules are turned on. After auditing the minimum number of flags needed to request single file compiler invocations that don't break with explict modules enabled, this change moves the remaining flags into clauses that only affect dynamic replacement mode. Updated unit tests to match (including some better formatting for the large parameter checks).
jonathanpenn
force-pushed
the
jpenn/preview-info-explicit-modules
branch
from
47fd72f to
9007eeb
Compare
neonichu
approved these changes
Mar 6, 2025
owenv
approved these changes
Mar 6, 2025
|
@swift-ci please test |
jakepetroules
approved these changes
Mar 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the new previews execution mode, we don't need to be as aggressive stripping compiler flags for thunk builds like we did for the old dynamic replacement execution mode. And doing so actually breaks when explicit modules are turned on. After auditing the minimum number of flags needed to request single file compiler invocations that don't break with explict modules enabled, this change moves the remaining flags into clauses that only affect dynamic replacement mode.
Updated unit tests to match (including some better formatting for the large parameter checks).