[swift] Always emit pch output path in OutputFileMap #261
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cachemeifyoucan
requested review from
jakepetroules,
mirza-garibovic,
mhrawdon,
neonichu and
owenv
as code owners
Always emit pch output path in OutputfileMap to support possible chained bridging header support. In the chained bridging header support mode, swift-driver can plan a generate PCH job even when there are no explicit bridging header is passed on command-line, and it needs the path in output file map to write the PCH file into desired location. Since having additional unused entries in the output file map is not an issue, just always generate output path for PCH in the output file map. rdar://146409233
cachemeifyoucan
force-pushed
the
eng/PR-146409233
branch
from
23e1152 to
77d02a2
Compare
|
@swift-ci please test |
neonichu
approved these changes
Mar 6, 2025
owenv
approved these changes
Mar 6, 2025
cachemeifyoucan
added a commit
to cachemeifyoucan/swift-build
that referenced
this pull request
Mar 8, 2025
After swift-driver #1832 and swift-build swiftlang#261, swift-build fully determines the pch output path. Adjust test to match both new and old behavior (with or without new swift-driver change).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Always emit pch output path in OutputfileMap to support possible chained bridging header support. In the chained bridging header support mode, swift-driver can plan a generate PCH job even when there are no explicit bridging header is passed on command-line, and it needs the path in output file map to write the PCH file into desired location. Since having additional unused entries in the output file map is not an issue, just always generate output path for PCH in the output file map.
rdar://146409233