Skip to content

fix all remaining typos in the Tests directory (including the code and the comments) #294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Mar 12, 2025
Merged

fix all remaining typos in the Tests directory (including the code and the comments) #294

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
59894c8
docs: fix spelling of 'successfully'
MojtabaHs Mar 12, 2025
9b2da81
fix: spelling of `forward`
MojtabaHs Mar 12, 2025
e6f1649
docs: fix spelling of `disabling`
MojtabaHs Mar 12, 2025
7ea3892
docs: fix spelling of `interfere`
MojtabaHs Mar 12, 2025
571c041
docs: fix a typo in `embed`
MojtabaHs Mar 12, 2025
f8d6ab5
Merge branch 'main' into fix-test-issues
MojtabaHs Mar 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Tests/SWBBuildSystemTests/BuildOperationTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5880,7 +5880,7 @@ That command depends on command in Target 'agg2' (project \'aProject\'): script
results.checkNoDiagnostics()
}

// Need to re-codesign based on the embedd; existing behavior that we should address too.
// Need to re-codesign based on the embed; existing behavior that we should address too.
try await tester.checkBuild(runDestination: .macOS, persistent: true, signableTargets: signableTargets) { _ in }

// Validate a null build.
Expand Down
2 changes: 1 addition & 1 deletion Tests/SWBBuildSystemTests/DevelopmentAssetsDiagnosticTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -344,7 +344,7 @@ fileprivate struct DevelopmentAssetsDiagnosticTests: CoreBasedTests {
@Test(.requireSDKs(.macOS))
func developmentAssetsOverriddenSRCROOT() async throws {
try await withTemporaryDirectory { tmpDirPath in
// Some environments override SRCROOT but that shouldn't interfer with relative paths in DEVELOPMENT_ASSET_PATHS since they are based in PROJECT_DIR
// Some environments override SRCROOT but that shouldn't interfere with relative paths in DEVELOPMENT_ASSET_PATHS since they are based in PROJECT_DIR
let testProject = TestProject(
"aProject",
sourceRoot: tmpDirPath,
Expand Down
2 changes: 1 addition & 1 deletion Tests/SWBCoreTests/SettingsTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3003,7 +3003,7 @@ import SWBMacro
let expected = settings.globalScope.evaluate(expectedMacro)
#expect(actual == expected)
if !expected {
// We do not currently emit any reasons for diabling in the notes.
// We do not currently emit any reasons for disabling in the notes.
#expect(settings.notes == [])
}
else {
Expand Down
2 changes: 1 addition & 1 deletion Tests/SWBUtilTests/FnmatchTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,7 +198,7 @@ import SWBUtil
}

@Test
func fowardAndBackSlashMatch() throws {
func forwardAndBackSlashMatch() throws {
// these test that '\' is handled correctly in character sets.
try assertFnmatch(pattern: "\\foo\\bar\\*\\", input: "\\foo\\bar\\baz\\baz\\")
try assertFnmatch(pattern: #"[\]"#, input: #"\"#)
Expand Down
4 changes: 2 additions & 2 deletions Tests/SwiftBuildTests/ArenaIndexingInfoTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -777,7 +777,7 @@ struct ArenaIndexingInfoTests: CoreBasedTests {
let info = try await IndexingInfoResults(infoProducer.generateIndexingInfo(target, .macOS, filePath: projectDir.join("main.c").str))
await info.checkIndexingInfo { info in
do {
// We should be able to successfuly run the resulting command line from indexing info
// We should be able to successfully run the resulting command line from indexing info
let success = try await Process.run(url: URL(fileURLWithPath: clangCompilerPath.str), arguments: info.clang.commandLineAsByteStrings.map { $0.asString }).isSuccess
#expect(success)
} catch {
Expand Down Expand Up @@ -860,7 +860,7 @@ struct ArenaIndexingInfoTests: CoreBasedTests {
let info = try await IndexingInfoResults(infoProducer.generateIndexingInfo(target, .macOS, filePath: projectDir.join("main.swift").str))
await info.checkIndexingInfo { info in
do {
// We should be able to successfuly run the resulting command line from indexing info
// We should be able to successfully run the resulting command line from indexing info
let success = try await Process.run(url: URL(fileURLWithPath: swiftCompilerPath.str), arguments: info.swift.commandLineAsByteStrings.map { $0.asString }).isSuccess
#expect(success)
} catch {
Expand Down