Simplify cross-platform hashing implementations #388
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owenv
requested review from
jakepetroules,
mirza-garibovic,
mhrawdon and
neonichu
as code owners
|
@swift-ci test |
|
@swift-ci test macOS |
owenv
force-pushed
the
owenv/simplify-hashing
branch
from
6bbc242 to
52b4ae3
Compare
|
@swift-ci test |
|
@swift-ci test linux |
|
@swift-ci test Windows |
owenv
force-pushed
the
owenv/simplify-hashing
branch
from
52b4ae3 to
03eed0b
Compare
|
@swift-ci test |
owenv
force-pushed
the
owenv/simplify-hashing
branch
from
03eed0b to
9a2d662
Compare
|
@swift-ci test |
jakepetroules
approved these changes
Apr 9, 2025
| super.init(impl: SwiftCryptoHashContext<Insecure.MD5>()) | ||
| #else | ||
| super.init(impl: VendoredSHA256HashContext()) |
There was a problem hiding this comment.
This seems a little shaky to use MD5 on Windows and Apple but SHA256 on other platforms. Do you plan to unify this further? I'm even surprised the tests pass like this.
There was a problem hiding this comment.
I think we should probably standardize on SHA256 everywhere in the future. Very few tests actually depend on the specific hash values, it's just important that they remain stable across builds performed by the same build system executable
Eliminate the package dependency on swift-crypto to simplify the bootstrapped build. Instead, vendor the SHA256 implementation from swift-tools-support-core and use it as a fallback if neither WinSDK nor CryptoKit is available.
owenv
force-pushed
the
owenv/simplify-hashing
branch
from
9a2d662 to
4e3949f
Compare
|
@swift-ci test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Eliminate the package dependency on swift-crypto to simplify the bootstrapped build. Instead, vendor the SHA256 implementation from swift-tools-support-core and use it as a fallback if neither WinSDK nor CryptoKit is available.