Fix typo in isCompatible
#440
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This just looks like a straight typo since `SpecializationParameters.toolchain` corresponds to the `TOOLCHAINS` build setting. I'm a bit surprised we have not seen this materialize in any bugs, but then again, customizing `TOOLCHAINS` is somewhat rare and hitting this would require two targets with different customizations of `TOOLCHAINS` to be depending on the same specialized target for the same platform.
neonichu
requested review from
jakepetroules,
mirza-garibovic,
mhrawdon and
owenv
as code owners
|
@swift-ci please test |
owenv
approved these changes
Apr 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This just looks like a straight typo since
SpecializationParameters.toolchaincorresponds to theTOOLCHAINSbuild setting. I'm a bit surprised we have not seen this materialize in any bugs, but then again, customizingTOOLCHAINSis somewhat rare and hitting this would require two targets with different customizations ofTOOLCHAINSto be depending on the same specialized target for the same platform.