Allow task spec to filter command line for signature #507
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
| @@ -69,8 +69,8 @@ open class TaskAction: PlannedTaskAction, PolymorphicSerializable | |||
| { | |||
| let md5 = InsecureHashContext() | |||
| md5.add(bytes: serializedRepresentationSignature!) | |||
| for arg in task.commandLine { | |||
| md5.add(bytes: arg.asByteString) | |||
| for arg in task.type.commandLineForSignature(for: task) ?? [] { | |||
There was a problem hiding this comment.
What is the meaning of a nil result here? Should the fallback be the regular command line instead of empty?
There was a problem hiding this comment.
ldaley
requested review from
aciidgh,
jakepetroules,
mhrawdon,
neonichu and
owenv
as code owners
mirza-garibovic
approved these changes
May 13, 2025
|
@swift-ci test |
neonichu
approved these changes
May 13, 2025
|
Nice catch, this was a bug waiting to happen! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This wires TaskTypeDescription#commandLineForSignature() into the default implementation of TaskAction#getSignature(), allowing task action implementations to get correct signature normalization by default.