Ignore -no_exported_symbols when the debug dylib is used (rdar://152244838)
#554
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…2244838) The stub executor needs to trampoline to the entry point in the debug dylib. But linking with `-no_exported_symbols` strips it and launching the app fails to find the symbol. Handles both the `LD_EXPORT_SYMBOLS` build setting and manual flags added to `OTHER_LDFLAGS`.
jonathanpenn
requested review from
jakepetroules,
mirza-garibovic,
mhrawdon,
neonichu,
owenv and
aciidgh
as code owners
Tests/SWBTaskConstructionTests/PreviewsTaskConstructionTests.swift
Outdated
Show resolved
Hide resolved
neonichu
approved these changes
Jun 4, 2025
|
@swift-ci test |
jakepetroules
approved these changes
Jun 4, 2025
|
Failing linux tests are crashes when running the macro evaluation tests, which are unrelated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The stub executor needs to trampoline to the entry point in the debug dylib. But linking with
-no_exported_symbolsstrips it and launching the app fails to find the symbol.Handles both the
LD_EXPORT_SYMBOLSbuild setting and manual flags added toOTHER_LDFLAGS.