SDK imports metadata #75
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neonichu
requested review from
jakepetroules,
mirza-garibovic and
owenv
as code owners
owenv
approved these changes
Feb 3, 2025
Sources/SWBTaskExecution/TaskActions/ProcessSDKImportsTaskAction.swift
Outdated
Show resolved
Hide resolved
|
@swift-ci test |
jakepetroules
approved these changes
Feb 4, 2025
|
@swift-ci test macOS |
1 similar comment
|
@swift-ci test macOS |
|
The optionality of |
neonichu
force-pushed
the
bbuegling/sdk-imports
branch
from
7b6ee62 to
5ef221c
Compare
|
@swift-ci test macOS |
This provides new metadata during builds: - Use the new `-sdk_imports` linker option when appropriate and provide a post-processed version of it as a resource in each bundle. - For each codeless bundle, "stamp" its Info.plist with any clients, this allows finding the library associated with a particular codeless bundle. Both behaviors are enabled by the `ENABLE_SDK_IMPORTS` build setting which defaults to the inverse of `ASSETCATALOG_COMPILER_SKIP_APP_STORE_DEPLOYMENT`.
…on.swift Co-authored-by: Owen Voorhees <[email protected]>
This provides new metadata during builds: - Use the new `-sdk_imports` linker option when appropriate and provide a post-processed version of it as a resource in each bundle. - For each codeless bundle, "stamp" its Info.plist with any clients, this allows finding the library associated with a particular codeless bundle. Both behaviors are enabled by the `ENABLE_SDK_IMPORTS` build setting which defaults to the inverse of `ASSETCATALOG_COMPILER_SKIP_APP_STORE_DEPLOYMENT`.
neonichu
force-pushed
the
bbuegling/sdk-imports
branch
from
5ef221c to
165e265
Compare
|
Refactored things a little bit so that we can also check whether the linker supports the SDK imports feature in tests. |
|
@swift-ci test macOS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This provides new metadata during builds:
-sdk_importslinker option when appropriate and provide a post-processed version of it as a resource in each bundle.Both behaviors are enabled by the
ENABLE_SDK_IMPORTSbuild setting which defaults to the inverse ofASSETCATALOG_COMPILER_SKIP_APP_STORE_DEPLOYMENT.