Fix CommandLineSpecTests
#88
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neonichu
requested review from
jakepetroules,
mirza-garibovic,
mhrawdon and
owenv
as code owners
|
@swift-ci please test |
mhrawdon
approved these changes
Feb 4, 2025
jakepetroules
approved these changes
Feb 5, 2025
|
The output is quite difficult to parse, but I think |
|
I think the actual failure is that |
|
Ah yes, I made the mistake of looking at the rendered output without noticing that it is actually just showing the tail of the log... |
|
@swift-ci please test |
I broke these in #31 since that added a new setting that needs to be manually applied in this particular test.
neonichu
force-pushed
the
bbuegling/fix-swiftTaskConstruction
branch
from
4c101cc to
ac91508
Compare
neonichu
changed the title
CommandLineSpecTests.swiftTaskConstruction()CommandLineSpecTests
|
@swift-ci please test |
|
@swift-ci test macOS |
|
Failure is |
|
I guess I need to rebase since the macOS job is now required. |
|
@swift-ci test macOS |
|
test issues should be fixed now |
|
@swift-ci test macOS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I broke these in #31 since that added a new setting that needs to be manually applied in this particular test.