Update macro usage bookkeeping when replacing a target with a dynamic variant #90
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owenv
requested review from
jakepetroules,
mirza-garibovic,
mhrawdon and
neonichu
as code owners
|
@swift-ci test |
neonichu
approved these changes
Feb 5, 2025
jakepetroules
approved these changes
Feb 5, 2025
|
I gave this a try on my real world project and unfortunately Xcode doesn't get very far before a crash in I've attached it below, am I able to provide any other information that might help nail down the cause? |
|
@Brett-Best when built in debug mode, there are a few parts of the macro evaluation subsystem which can overflow the stack due to a missing tail call optimization on larger projects. I expect a release build wouldn't hit that crash. |
|
I'm not sure if it's possible but the little plugin that launches Xcode, it would be good if that could be configured to do release builds. I'll do it manually and invoke the same set of commands and get back to you! Appreciate the PR and responses! |
|
Confirmed that this PR fixes the issue we were facing and building in release fixes the crash above. TYSM! |
|
@swift-ci please test macOS |
neonichu
added a commit
that referenced
this pull request
Feb 5, 2025
Was suggested in #90 (comment) and I think it makes sense since the main use case of the plugin is probably to test "real" projects which are more likely to not work in debug builds.
|
@swift-ci test macOS |
neonichu
added a commit
that referenced
this pull request
Feb 6, 2025
Was suggested in #90 (comment), this adds support for `--release` and `--configuration release` to switch to release config.
neonichu
added a commit
that referenced
this pull request
Feb 7, 2025
Was suggested in #90 (comment), this adds support for `--release` and `--configuration release` to switch to release config.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we failed to update swiftMacroImplementationDescriptorsByTarget, targetsRequiredToBuildForIndexing, and targetsWhichShouldBuildModulesDuringInstallAPI when doing this replacement.
Resolves #73