Skip to content

Update CODEOWNERS for String Catalog integration #91

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 5, 2025

Conversation

matthewseaman
Copy link
Contributor

Adding myself and @kulpreetchilana to CODEOWNERS for files involving String Catalog integration.
Also keeping the existing owners.

@owenv
Copy link
Collaborator

owenv commented Feb 5, 2025

@swift-ci test

Copy link
Collaborator

@jakepetroules jakepetroules left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think you need to add the rest of us here; global CODEOWNERS should be cumulative with topic-specific ones, isn't it?

@matthewseaman
Copy link
Contributor Author

I don't think you need to add the rest of us here; global CODEOWNERS should be cumulative with topic-specific ones, isn't it?

Sadly according to the GitHub docs the last matching line takes precedence over anything before it.
https://docs.github.com/en/enterprise-cloud@latest/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-code-owners

# Order is important; the last matching pattern takes the most
# precedence. When someone opens a pull request that only
# modifies JS files, only @js-owner and not the global
# owner(s) will be requested for a review.
*.js    @js-owner #This is an inline comment.

@jakepetroules
Copy link
Collaborator

I don't think you need to add the rest of us here; global CODEOWNERS should be cumulative with topic-specific ones, isn't it?

Sadly according to the GitHub docs the last matching line takes precedence over anything before it. https://docs.github.com/en/enterprise-cloud@latest/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-code-owners

# Order is important; the last matching pattern takes the most
# precedence. When someone opens a pull request that only
# modifies JS files, only @js-owner and not the global
# owner(s) will be requested for a review.
*.js    @js-owner #This is an inline comment.

Huh, that's annoying.

@matthewseaman matthewseaman merged commit 0e7dda7 into main Feb 5, 2025
1 of 2 checks passed
@matthewseaman matthewseaman deleted the mseaman/add-to-codeowners branch February 5, 2025 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants