config: generalise more things to be detected #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This converts many of the checks to be dynamic to support different compilers. Windows uses cl which does not support `__builtin_expect` nor does it support `__attribute__`. This should help repair the Windows build.
|
CC: @akyrtzi @shahmishal |
|
Spun off a test run at swiftlang/swift#27589. This should repair the community CI builds on Windows. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This converts many of the checks to be dynamic to support different
compilers. Windows uses cl which does not support
__builtin_expectnor does it support
__attribute__. This should help repair theWindows build.