-
Notifications
You must be signed in to change notification settings - Fork 108
[Bugfix] Fix the backticks bug #26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I do not know this will break any other situation. But this did address the issue of wrongly parse backticks mentioned in the SR-15415. When parse "`" and "``" |
Can you make sure to run |
Assuming this is code from upstream cmark, could we fix it in upstream and then sync-up the fork instead? |
Add a clean PR to the upstream. See commonmark#427 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much for adding the test, and for posting the patch upstream! It looks like they've already taken a look, which is nice. This looks good to go for me, now.
Thank you! 🙇🏻♂️ |
SR-15415