[CMake] Export the CMark targets #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This creates a CMarkExports.cmake file that exports the cmark library and executable targets. This can be consumed by Swift so that Swift can depend on CMark's targets without needing to specify the absolute paths to libraries.
|
Either of you have any objection to this change? It will allow us to directly import CMark's targets into Swift's CMake build, which will simplify some of the handling of the CMark library. |
|
Can you take this upstream, please? |
llvm-beanz
pushed a commit
to llvm-beanz/swift
that referenced
this pull request
Feb 6, 2017
This change depends on: swiftlang/swift-cmark#4
|
Let's take this now here, and look to upstream it. |
llvm-beanz
pushed a commit
to llvm-beanz/swift
that referenced
this pull request
Feb 7, 2017
This change depends on: swiftlang/swift-cmark#4
llvm-beanz
pushed a commit
to llvm-beanz/swift
that referenced
this pull request
Feb 8, 2017
This change depends on: swiftlang/swift-cmark#4
franklinsch
pushed a commit
that referenced
this pull request
Oct 13, 2021
* Include table alignment when rendering LaTeX * Include table alignment when rendering man (preserving default centre alignment here) * Trim table cell interiors * Expand test cases * Fix escaping behaviour * Do not use enum for alignment * Do not collide against stdlib `ispunct` * Cleanup pipe code * Don't reparse matched rows
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This creates a CMarkExports.cmake file that exports the cmark library and executable targets. This can be consumed by Swift so that Swift can depend on CMark's targets without needing to specify the absolute paths to libraries.