build: only attempt to install MSVC system libraries on Windows #6
Conversation
Newer versions of CMake attempt to query the system for information about the VS 2017 installation. Unfortunately, this query fails on non-Windows systems when cross-compiling: cmake_host_system_information does not recognize <key> VS_15_DIR CMake will not find these system libraries on non-Windows hosts anyways, and we were silencing the warnings, so simply omit the installation when cross-compiling to Windows.
|
@swift-ci please test |
|
Is this something we can fix in upstream CMark instead? |
|
@jrose-apple, hmm, I can certainly create a pull request there as well, but this definitely is something that I think we should have in the mean time. But, thanks for the reminder that there is an upstream to this! |
|
Created commonmark#265 to get this merged upstream. It definitely has diverged, so cherry-picking wont work cleanly BTW. |
|
Hm. I don't remember what our process is for updating to the latest CMark. @najacque, @tkremenek? |
|
@jrose-apple - thoughts on merging this until we get this tree updated from upstream? (commonmark#265 is merged!) |
|
I think it's okay. I feel like it's the same thing as cherry-picking an upstream LLVM change. |
|
@jrose-apple - seems that I don't have merge access on this repository. Would you mind helping? |
|
Done! |
|
We do not have a regular process for updating this repository against upstream, but now would be a good time. |
Newer versions of CMake attempt to query the system for information about the VS
2017 installation. Unfortunately, this query fails on non-Windows systems when
cross-compiling:
CMake will not find these system libraries on non-Windows hosts anyways, and we
were silencing the warnings, so simply omit the installation when
cross-compiling to Windows.