Skip to content

mark a local variable as const #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

compnerd
Copy link
Member

Visual Studio 2017 objects to the assignment due to the dropped
qualifiers.

Visual Studio 2017 objects to the assignment due to the dropped
qualifiers.
@compnerd
Copy link
Member Author

CC: @jrose-apple

I'm also going to try to upstream this.

@compnerd
Copy link
Member Author

Bleh, seems that upstream has diverged and may have fixed this already (but differently).

@jrose-apple
Copy link

cc @akyrtzi

@compnerd
Copy link
Member Author

compnerd commented Dec 1, 2018

Seems that I don't have write access to this repository (@tkremenek?) ... could someone please merge this on my behalf?

@akyrtzi
Copy link

akyrtzi commented Dec 2, 2018

I don't have write access either.

@tkremenek
Copy link
Member

We really don't like to push these kinds of changes to swift-cmark fork, but instead push them upstream first. Does it make sense to upgrade to a newer version of swift-cmark at this point?

@compnerd
Copy link
Member Author

compnerd commented Dec 3, 2018

@tkremenek - yeah, updating to a newer revision of cmark is probably a good approach to resolving the issue.

@akyrtzi
Copy link

akyrtzi commented Dec 4, 2018

I asked @nkcsgexi to look into how complicated (or not) it would be to try to upgrade.

@akyrtzi
Copy link

akyrtzi commented Dec 6, 2018

This has been superseded on master by #8, if you need it in swift-5.0 branch open a PR on that branch with this minimal change.

@compnerd compnerd closed this Dec 7, 2018
@compnerd compnerd deleted the const branch December 7, 2018 02:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants