Skip to content

Add aarch64 node #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 18, 2018
Merged

Add aarch64 node #10

merged 2 commits into from
Jun 18, 2018

Conversation

futurejones
Copy link
Contributor

Add node for arm64/aarch64 ubuntu 16.04

Copy link

@vielmetti vielmetti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, looking forward to seeing this added.

@vielmetti
Copy link

PR should include an update to the README file too

https://github.com/apple/swift-community-hosted-continuous-integration/blob/master/README.md

@shahmishal shahmishal self-requested a review June 16, 2018 00:28
@shahmishal
Copy link
Member

@futurejones Email sent for additional information.

@vielmetti
Copy link

@shahmishal Happy to also be part of the conversation if you have any questions about @packethost and the Works on Arm program.

Copy link
Member

@shahmishal shahmishal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shahmishal
Copy link
Member

@futurejones / @vielmetti Did you want to add a bot for master branch too?

@shahmishal shahmishal merged commit 4d4c79a into swiftlang:master Jun 18, 2018
@shahmishal
Copy link
Member

@futurejones, are you aware of the current failure?

Foundation/NSString.swift:1182:106: error: cannot convert value of type 'CVaListPointer' to expected argument type 'va_list' (aka '__va_list')
        let str = CFStringCreateWithFormatAndArguments(kCFAllocatorSystemDefault, nil, format._cfObject, argList)!
                                                                                                         ^~~~~~~
Foundation/NSString.swift:1190:148: error: cannot convert value of type 'CVaListPointer' to expected argument type 'va_list' (aka '__va_list')
                str = CFStringCreateWithFormatAndArguments(kCFAllocatorSystemDefault, unsafeBitCast(loc, to: CFDictionary.self), format._cfObject, argList)
                                                                                                                                                   ^~~~~~~
Foundation/NSString.swift:1195:106: error: cannot convert value of type 'CVaListPointer' to expected argument type 'va_list' (aka '__va_list')
            str = CFStringCreateWithFormatAndArguments(kCFAllocatorSystemDefault, nil, format._cfObject, argList)
                                                                                                         ^~~~~~~
Foundation/NSString.swift:1202:100: error: cannot convert value of type 'CVaListPointer' to expected argument type 'va_list' (aka '__va_list')
            CFStringCreateWithFormatAndArguments(kCFAllocatorSystemDefault, nil, format._cfObject, vaPtr)
                                                                                                   ^~~~~

https://ci-external.swift.org/job/oss-swift-RA-linux-ubuntu-16.04-aarch64/4/console
https://ci-external.swift.org/job/oss-swift-4.1-RA-linux-ubuntu-16.04-aarch64/1/console
https://ci-external.swift.org/job/oss-swift-4.2-RA-linux-ubuntu-16.04-aarch64/5/console

@futurejones futurejones deleted the aarch64-node branch June 19, 2018 22:32
@futurejones
Copy link
Contributor Author

Yes I am aware of these issues.
A PR was submitted on Mar 12 to fix this.
swiftlang/swift#15174

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants