[SR-4905] Store cookies in XDG_DATA_HOME instead of XDG_CONFIG_HOME #1000
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
1000th pull request ! |
mamabusi
force-pushed
the
storeCookieInDataHome
branch
from
4d79715 to
b491d22
Compare
|
@swift-ci test |
|
@swift-ci please test |
mamabusi
force-pushed
the
storeCookieInDataHome
branch
from
b491d22 to
b1ccf49
Compare
|
@pushkarnk Could you please run the CI Build again. I have pushed in the necessary changes to fix the test-failures. |
|
@swift-ci please test |
1 similar comment
|
@swift-ci please test |
|
@pushkarnk @parkera The CI test-failure seen is because of a bug in Cookie Storage where it fails to create non-existing parent directories. A fix for this is already available in the open PR: #1003 |
|
@swift-ci test and merge |
mamabusi
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.