Add support for currentDirectoryPath in Process class #1008
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattrajca
changed the title
parkera
reviewed
May 24, 2017
Foundation/Process.swift
Outdated
| } | ||
|
|
||
| // posix_spawn doesn't support passing a custom working directory, so resort to chdir. | ||
| return chdir(rawPath) == 0 |
There was a problem hiding this comment.
Am I missing something, or don't we have to reset this value after we're done with the launch?
There was a problem hiding this comment.
@parkera Good catch, I updated the commit.
|
@parkera please review the revised commit. |
|
Looks good, thanks. Can you just do one more thing for me and add a couple lines to the test to 1. get the CWD before/after and comparing, to verify that we did that correctly too. |
This patch adds support for the `currentDirectoryPath` property on `Process` Since `posix_spawn` doesn't make it easy to change the working directory, a call to `chdir` is issued just before the process executes. It looks like `lldb` follows a similar pattern in one of its tools (`tools/darwin-debug/darwin-debug.cpp`).
|
@parkera: Done! Please re-review the latest commit. |
|
@swift-ci please test |
|
@parkera Good to go? |
|
Yes, thanks for taking this one on! |
|
@swift-ci test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds support for the
currentDirectoryPathproperty onProcessSince
posix_spawndoesn't make it easy to change the working directory, acall to
chdiris issued just before the process executes. It looks likelldbfollows a similar pattern in one of its tools(
tools/darwin-debug/darwin-debug.cpp).This also addresses SR-3524