Update to Swift 4 #1022
Update to Swift 4 #1022
Conversation
spevans
force-pushed
the
pr_swift4_only
branch
3 times, most recently
from
a843648 to
939d2fc
Compare
spevans
force-pushed
the
pr_swift4_only
branch
2 times, most recently
from
4c7a1b9 to
9517d5e
Compare
|
Are we good to go on this one? |
|
No there are still a few closure issues that popped up. I saw that some of SE-110 was reverted but I dont think it has been fully done. I will do a quick test and see what is still broken |
|
There were some changes still needed but mostly it was listing the exact number of arguments before The PR for the rollback of SE110 is swiftlang/swift#10414 |
|
@parkera If you are happy with the closure changes I think this is good to go |
| @@ -109,16 +109,16 @@ open class NotificationQueue: NSObject { | |||
| var predicate: (NSNotificationListEntry) -> Bool | |||
| switch coalesceMask { | |||
| case [.onName, .onSender]: | |||
| predicate = { (entryNotification, _) in | |||
| return _SwiftValue.store(notification.object) !== _SwiftValue.store(entryNotification.object) || notification.name != entryNotification.name | |||
| predicate = { entry in | |||
There was a problem hiding this comment.
Could this one have remained as previous with the SE-110 revert?
There was a problem hiding this comment.
Unfortunately these three still gave the error 'does not support destructuring' even after I checked it with the latest compiler, but it was the only ones.
There was a problem hiding this comment.
Maybe we should follow up on that separately but it shouldn't hold this up.
|
One small question but otherwise looks good |
|
@swift-ci test and merge |
Changes only compatible with swift 4.
Depends on:
#995(but requires SE-110 to be reverted)#1023#1024