build: Fix TestFoundation to build and run in Xcode #1038
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- The paths to the built frameworks needed updating so that TestFoundation will now correctly build in Xcode and link with XCTest. - Use the correct name to the xdgTestHelper which is different on Linux and macOS. - The test HTTP server now listens on 127.0.0.1 instead of 0.0.0.0 so that the firewall dialog doesnt popup on macOS if the firewall is enabled.
|
@swift-ci test and merge |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The paths to the built frameworks needed updating so that
TestFoundation will now correctly build in Xcode and link
with XCTest.
Use the correct name to the xdgTestHelper which is different on
Linux and macOS.
The test HTTP server now listens on 127.0.0.1 instead of 0.0.0.0
so that the firewall dialog doesnt popup on macOS if the firewall
is enabled.
This PR works in conjunction with swiftlang/swift-corelibs-xctest#192 for swift-corelibs-xctest
This will fix building SwiftFoundation and then running TestFoundation in Xcode, correctly linking to SwiftXCTest. It requires the xctest PR listed above to work. Some of the tests are still broken on macOS but this should make it easier to fix them now. Also one bug was found by the malloc debugger so that fix is included here.
Tested on Xcode 8.3.3 and 9.0 beta with 2017-06-11 nightly toolchain.