NSMutableURLRequest implementation #104
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if _httpHeaderFields == nil { | ||
| _httpHeaderFields = [:] | ||
| } | ||
| _httpHeaderFields?[field.lowercaseString] = value |
There was a problem hiding this comment.
The Obj-C Foundation framework preserves the capitalization as entered (as seen in what is returned from allHTTPHeaderFields), though is otherwise indeed case insensitive. Keeping the capitalization as is helps with readability during debugging network calls.
…t evaluated insensitively
|
@johankool Updated code to store the values with supplied case but evaluate them for setting / adding as insensitive. It's a little strange that NSMutableURLRequest provides case insensitive setters but no such getters. |
…uest convenience initalizers
phausler
added a commit
that referenced
this pull request
Dec 10, 2015
NSMutableURLRequest implementation
atrick
pushed a commit
to atrick/swift-corelibs-foundation
that referenced
this pull request
Jan 12, 2021
Use SPM UserToolchain. …
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I didn't implement this to avoid changing the interface, but I think it would make sense going forward to change NSURLRequest's init(NSURL) method from convenience to required and mark the URL property as non-optional.