Fix for URLSession redirect does not inherit request timeout value[SR… #1063
Conversation
|
@saiHemak does this maybe fix problems with |
| } | ||
| } | ||
|
|
||
| func getTimetaken() -> Double { |
There was a problem hiding this comment.
Spelling: should be getTimeTaken().
| } | ||
|
|
||
| func getTimetaken() -> Double { | ||
| let timeTaken = UnsafeMutablePointer<Double>.allocate(capacity: 8) |
There was a problem hiding this comment.
This is not correct. You are allocating 8 instances of type Double. The body of this function should be:
var timeSpent = Double()
CFURLSession_easy_getinfo_double(rawHandle, CFURLSessionInfoTOTAL_TIME, &timeSpent)
return timeSpentSince this is used only for subtracting from the timeout interval, it might be worthwhile to return timeSpent / 1000 and to rename this function getTimeoutIntervalSpent().
saiHemak
force-pushed
the
nsredirect
branch
2 times, most recently
from
3a7cb8f to
731498c
Compare
|
@swift-ci please test |
1 similar comment
|
@swift-ci please test |
|
@bubski I could see the test case |
|
@saiHemak I pulled newest changes and the problem went away. |
|
@swift-ci test and merge |
…-2682]