Split up a couple expressions to work around slow type checking. #1077
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The type checker is particularly slow on these expressions. I've opened https://bugs.swift.org/browse/SR-5322 to investigate the type checker issue, but in the meantime it would be nice to speed up builds. This cuts more than a minute from my unoptimized asserts-enabled build.
|
@swift-ci Please smoke test |
|
@parkera Is this okay to merge? |
|
Can we put a SR or radar number in the comment so we know when it's ok to remove this hack? |
Add the SR number to the comment. I've also updated the SR to point back to the PR for the work-around so that we know to revert the change when the issue is resolved.
|
Sure - I've added a commit that mentions the SR number, and updated the SR to point back to this PR so that we know to revert it once the type checker performance issue is resolved. |
|
@swift-ci Please smoke test |
|
@swift-ci please test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The type checker is particularly slow on these expressions. I've opened
https://bugs.swift.org/browse/SR-5322to investigate the type checkerissue, but in the meantime it would be nice to speed up builds. This
cuts more than a minute from my unoptimized asserts-enabled build.