Skip to content

NSDecimalNumberHandler: default is now a property #1079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 29, 2017

Conversation

ianpartridge
Copy link
Contributor

The change is shown at https://developer.apple.com/documentation/foundation/nsdecimalnumberhandler/1407825-default?changes=latest_minor

I haven't been able to test this yet because the Xcode build is currently broken. But it looks fairly simple.

@phausler
Copy link
Contributor

is there a bug on the Xcode build failure?

@ianpartridge
Copy link
Contributor Author

I posted on the the mailing list with a workaround for it.

@pushkarnk
Copy link
Member

@swift-ci please test

@ianpartridge
Copy link
Contributor Author

I think this is ready to merge.

Aside: we're trying to find a more systematic way to identify API changes that need to be made to swift-corelibs-foundation before Swift 4 ships.

@pushkarnk pushkarnk merged commit 26e3b89 into swiftlang:master Jun 29, 2017
@ianpartridge ianpartridge deleted the nsdecimalnumberhandler branch June 29, 2017 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants