fix Operation.isExecuting #1080
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
phausler
approved these changes
Jun 27, 2017
|
@swift-ci please test |
|
@swift-ci please test and merge |
|
@phausler I can't see the results of the CI run here even though we both asked to test it. Any idea what's going on? |
|
@swift-ci please test and merge |
1 similar comment
|
@swift-ci please test and merge |
|
Sometimes swift-ci ignores certain channels for some reason. This change looks solid to me. |
|
@phausler dang, forgot to record a little change in the tests so tests will fail :. Pushing a new commit any second now |
|
@swift-ci please test |
1 similar comment
|
@swift-ci please test |
|
@phausler this now passed the checks. Didn't merge it as I made some (cosmtic) changes in the tests and wanted to give you the chance to have a look at that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.