URLProtocolClient doesn't deliver response and data to URLSession delegates #1084
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pushkarnk
requested changes
Jun 28, 2017
| guard let task = `protocol`.task else { fatalError("Received response, but there's no task.") } | ||
| task.response = response | ||
| let session = task.session as! URLSession | ||
| guard let dt = task as? URLSessionDataTask else { return } |
There was a problem hiding this comment.
nit: Can we have a better name for the local here? May be dataTask
pushkarnk
requested changes
Jun 28, 2017
| let dataDelegate = delegate as? URLSessionDataDelegate | ||
| let dataTask = task as? URLSessionDataTask | ||
| session.delegateQueue.addOperation { | ||
| dataDelegate?.urlSession(session, dataTask: dataTask!, didReceive: `protocol`.properties[URLProtocol._PropertyKey.responseData] as! Data) |
There was a problem hiding this comment.
We can simply use data as the didReceive argument here!
|
@nethraravindran Can you please edit the commit message so that it indicates the problem in the Foundation context? Thanks. |
pushkarnk
approved these changes
Jun 28, 2017
|
@swift-ci please test and merge |
1 similar comment
|
@swift-ci please test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Custom URLProtocols using task delegates doesn't deliver data and response received to the URLSession delegates. This fix would delegate the data and response to url session delegates.