OperationQueue.main dangling pointer fix #1094
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calling
OperationQueue.main
wouldinstantiate an
OperationQueue
,set an
Unmanaged
reference to it as main queue specificand return
OperationQueue
.Subsequent calls to
OperationQueue.main
wouldget the
Unmanaged
reference toOperationQueue
from main queue specificand return
OperationQueue
wrapped inUnmanaged
.However, there's nothing stopping the
OperationQueue
from being deallocated, so theUnmanaged
reference from subsequent call would in fact return garbage.