fix tests dying because of SIGPIPE #1099
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
|
Looks good to me. |
phausler
reviewed
Jul 6, 2017
| @@ -46,6 +48,8 @@ class TestURLSession : XCTestCase { | |||
|
|
|||
| override class func setUp() { | |||
| super.setUp() | |||
|
|
|||
| _ = signal(SIGPIPE, SIG_IGN) | |||
There was a problem hiding this comment.
we might want to add this earlier in the lifecycle (e.g. main.swift) so that it applies equally to all tests (perhaps we might add more in the future that will need this
There was a problem hiding this comment.
@phausler agreed, good idea! Will update.
|
@phausler updated |
|
@swift-ci please test |
(`POSIX` sends `SIGPIPE` when writing to a closed fd)
|
@swift-ci please test |
1 similar comment
|
@swift-ci please test |
|
was there a specific situation where a closed fd was being written to or is it just to cover potential future issues? |
|
@spevans there was a test that was failing because of that, I think |
|
@swift-ci please test and merge |
|
@swift-ci test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(POSIX sends
SIGPIPEwhen writing to a closed fd which will then kill your project unless you ignore it or handle it properly)