Several compilation warnings resolved #1106
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bubski
commented
Jul 10, 2017
| IndexPath(indexes: [Int.max >> 8, 2, Int.max >> 36]).hashValue // this should not cause an overflow crash | ||
|
|
||
| // this should not cause an overflow crash | ||
| let hash: Int? = IndexPath(indexes: [Int.max >> 8, 2, Int.max >> 36]).hashValue |
There was a problem hiding this comment.
Is this reasonable? Or is guaranteed that compiler will not optimize out the below to a no-op?
_ = IndexPath(indexes: [Int.max >> 8, 2, Int.max >> 36]).hashValue
There was a problem hiding this comment.
eh the assert below validates the non-crash case; and it is a test of an overflow so I think it should be fine as you have it
phausler
approved these changes
Jul 10, 2017
| IndexPath(indexes: [Int.max >> 8, 2, Int.max >> 36]).hashValue // this should not cause an overflow crash | ||
|
|
||
| // this should not cause an overflow crash | ||
| let hash: Int? = IndexPath(indexes: [Int.max >> 8, 2, Int.max >> 36]).hashValue |
There was a problem hiding this comment.
eh the assert below validates the non-crash case; and it is a test of an overflow so I think it should be fine as you have it
|
@swift-ci please test and merge |
ianpartridge
added a commit
to ianpartridge/swift
that referenced
this pull request
Jul 11, 2017
This was removed in `swift-corelibs-foundation` in swiftlang/swift-corelibs-foundation#1106 Make the same change to the overlay version, to keep them in sync.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several compilation warnings resolved