[test] Simplify expression in a test #1124
Merged
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test |
|
Since this removes the clarity of where the parenthesis lies (is this 1 as Uint or express Uint?) this actually makes the initialiser worse in my opinion.
Can you clarify why you think this is an improvement?
Sent from my iPhone 📱
… On 21 Jul 2017, at 21:27, Maxim Moiseev ***@***.***> wrote:
@swift-ci Please test
Will it work?...
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
On Jul 21, 2017, at 2:00 PM, Alex Blewitt ***@***.***> wrote:
Since this removes the clarity of where the parenthesis lies (is this 1 as Uint or express Uint?) this actually makes the initialiser worse in my opinion.
Can you clarify why you think this is an improvement?
Because it makes test compile.
…
Sent from my iPhone 📱
> On 21 Jul 2017, at 21:27, Maxim Moiseev ***@***.***> wrote:
>
> @swift-ci Please test
> Will it work?...
>
> —
> You are receiving this because you are subscribed to this thread.
> Reply to this email directly, view it on GitHub, or mute the thread.
>
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub <#1124 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAD6C4Z15-noLGG-Go_TJhA5vmqufiFrks5sQRFmgaJpZM4Of2ma>.
|
|
@alblue I am more than willing to reinstate the clarity, but to me expression without parens is the best it can be. Adding parens like this |
|
It's not clear why you claim that it makes the test compile since the test is compiling previously?
Sent from my iPhone 📱
… On 21 Jul 2017, at 22:17, Maxim Moiseev ***@***.***> wrote:
@alblue I am more than willing to reinstate the clarity, but to me expression without parens is the best it can be. Adding parens like this 1<<18 + 1<<17 + (1 as UInt32) only makes it worse, without changing the behavior.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
|
This expression became too complex due to the changes introduced in swiftlang/swift#11044
|
@alblue Turns out completely removing the |
|
I guess this is ok; seems unfortunate to have to hack around compiler limitations like this but if we don't have a choice then we're ok to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This expression became too complex due to the changes introduced in
swiftlang/swift#11044