Skip to content

Update access controls in NSSortDescriptor #1133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 25, 2017
Merged

Update access controls in NSSortDescriptor #1133

merged 1 commit into from
Jul 25, 2017

Conversation

DunnCoding
Copy link
Contributor

Fixes incorrect access controls with the new keyPath APIs in NSSortDescriptor.

DunnCoding
DunnCoding commented Jul 25, 2017
View reviewed changes
Foundation/NSSortDescriptor.swift
@@ -35,13 +35,13 @@ open class NSSortDescriptor: NSObject, NSSecureCoding, NSCopying {

open var key: String? { NSUnimplemented() }
open var ascending: Bool { NSUnimplemented() }
var keyPath: AnyKeyPath? { NSUnimplemented() }
public var keyPath: AnyKeyPath? { NSUnimplemented() }
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ikesyo I've made this public to match the implementation within the overlay as can be seen here

@parkera
Copy link
Contributor

parkera commented Jul 25, 2017

@swift-ci test and merge

@swift-ci swift-ci merged commit 65005c6 into swiftlang:master Jul 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DunnCoding @parkera @swift-ci