Replace precondition if with guard in NSNumber.encode. #1143
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously NSNumber.encode would call NSUnimplemented when you try to do a keyed coding. Whilst it is true that this wasn't implemented it was due to not being possible rather than not yet implemented. With this patch we call preconditionFailure which is more consistent with the rest of the project. We also use a guard so can remove a level of indentation.
|
@swift-ci please test |
|
LGTM. What do you think @ianpartridge @phausler ? NB when viewing the diffs, put ?w=1 at the end so it's less noisy ... |
|
Yes I think this is fine. Thanks @oc243 |
|
@swift-ci please test and merge |
|
Looks like an unrelated segfault:
@swift-ci please test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously NSNumber.encode would call NSUnimplemented when you try to
do a keyed coding. Whilst it is true that this wasn't implemented it was
due to not being possible rather than not yet implemented.
With this patch we call preconditionFailure which is more consistent
with the rest of the project. We also use a guard so can remove a level of
indentation.